chore(transport): retire the legacy TCP package by yordis · Pull Request #498 · TrogonStack/TrogonEventStore

yordis · 2026-09-12T23:22:35Z

Prevents the retired transport from remaining buildable or distributable by accident.

cursor · 2026-09-12T23:22:40Z

PR Summary

Medium Risk
Removes a large legacy networking layer; runtime impact is low if nothing still depended on it, but TLS behavior is now validated only on HTTP/gRPC paths.

Overview
Retires EventStore.Transport.Tcp by dropping the project from the solution and deleting its TCP/SSL connection stack, framing, and related tests plus embedded TCP test CAs.

TLS coverage moves to current transports: new Kestrel-based tests exercise mutual TLS for HTTP (NodeHttpClientFactory + ClusterVNode cert validators) and gRPC replication (trusted client cert → certificate identity; missing client cert → Unauthenticated).

Build/CI cleanup: EventStore.Core.Tests no longer references the TCP project or TCP embedded certs; the test image no longer installs a TCP test CA or runs update-ca-certificates. Central package list drops unused EventStore.Client.

^{Reviewed by Cursor Bugbot for commit 5b77efa. Bugbot is set up for automated code reviews on this repo. Configure here.}

coderabbitai · 2026-09-12T23:23:12Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7761045f-e617-431e-8c8f-de8df6d607c1

📥 Commits

Reviewing files that changed from the base of the PR and between 39a8db8 and 5b77efa.

📒 Files selected for processing (4)

Dockerfile
scripts/test.sh
src/EventStore.Core.Tests/Services/Transport/Grpc/Replication/ReplicationMutualTlsTests.cs
src/EventStore.Core.Tests/Services/Transport/Http/ssl_connections_mutual_auth.cs

💤 Files with no reviewable changes (1)

Dockerfile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request removes the EventStore.Transport.Tcp project and its formatting, framing, connection, listener, SSL, pooling, configuration, monitoring, and statistics code. It also adds mutual TLS tests for HTTP connections and gRPC replication, and removes test-container setup for a CA certificate.

Changes

TCP transport removal

Layer / File(s)	Summary
Project and solution removal `src/Directory.Packages.props`, `src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj`, `src/EventStore.sln`	The TCP project and its solution configuration entries are removed. The central `EventStore.Client` version entry is also removed.
Formatting and framing removal `src/EventStore.Transport.Tcp/Formatting/`, `src/EventStore.Transport.Tcp/Framing/`	Formatter interfaces and implementations, length-prefix framers, and `PackageFramingException` are removed.
Connection and monitoring removal `src/EventStore.Transport.Tcp/ITcpConnection.cs`, `src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs`, `src/EventStore.Transport.Tcp/Tcp*.cs`, `src/EventStore.Transport.Tcp/SocketArgsPool.cs`, `src/EventStore.Transport.Tcp/Helper.cs`	TCP and SSL connections, client and server socket handling, pooling, configuration, monitoring, statistics, helper methods, and typed connection wrapping are removed.

Mutual TLS tests

Layer / File(s)	Summary
HTTP mutual TLS connection tests `src/EventStore.Core.Tests/Services/Transport/Http/ssl_connections_mutual_auth.cs`, `Dockerfile`, `scripts/test.sh`	HTTP tests cover certificate trust and validation combinations, including absent client or server certificates. The test container no longer installs the CA certificate or refreshes the system certificate bundle.
Replication mutual TLS tests `src/EventStore.Core.Tests/Services/Transport/Grpc/Replication/ReplicationMutualTlsTests.cs`	Tests verify that a trusted client certificate reaches replication as a certificate identity and that a connection without a client certificate receives an `Unauthenticated` status without publishing messages.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5b77e

This change retires the legacy TCP transport and adds mutual TLS tests for HTTP and gRPC replication. No remaining code or build configuration depends on the removed package or its test certificate. The new tests set up their own trust roots and do not rely on the system certificate store. No merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: retirement of the legacy TCP transport package.
Description check	✅ Passed	The description relates directly to the changes, which remove the legacy transport project and prevent accidental build or distribution.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks the socket’s place
Then tests TLS at a careful pace
A trusted cert can state its name
No client cert brings no message claim
The old TCP files rest away
And buns applaud the tests today
One hop, one check, then off to play}

_{Comment @coderabbitai help to get the list of available commands.}